Hi Sakari,
Thanks for the patch.
On Tuesday 06 March 2012 18:33:11 Sakari Ailus wrote:
> Perform CCDC link validation in ccdc_link_validate() instead of
> isp_video_validate_pipeline(). Also perform maximum data rate check in
> isp_video_check_external_subdevs().
>
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxx>
[snip]
> diff --git a/drivers/media/video/omap3isp/ispvideo.c
> b/drivers/media/video/omap3isp/ispvideo.c index 6d4ad87..51075b3 100644
> --- a/drivers/media/video/omap3isp/ispvideo.c
> +++ b/drivers/media/video/omap3isp/ispvideo.c
[snip]
> @@ -950,6 +867,7 @@ static int isp_video_check_external_subdevs(struct
> isp_pipeline *pipe) struct v4l2_subdev_format fmt;
> struct v4l2_ext_controls ctrls;
> struct v4l2_ext_control ctrl;
> + unsigned int rate = UINT_MAX;
You can move this variable inside the if statement below.
> int i;
> int ret = 0;
>
> @@ -1002,6 +920,16 @@ static int isp_video_check_external_subdevs(struct
> isp_pipeline *pipe)
>
> pipe->external_rate = ctrl.value64;
>
> + if (pipe->entities & (1 << isp->isp_ccdc.subdev.entity.id)) {
> + /*
> + * Check that maximum allowed CCDC pixel rate isn't
> + * exceeded by the pixel rate.
What's wrong with 80 columns, really ? :-)
> + */
> + omap3isp_ccdc_max_rate(&isp->isp_ccdc, &rate);
> + if (pipe->external_rate > rate)
> + return -ENOSPC;
> + }
> +
> return 0;
> }
Pending those two changes,
Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
