Hi Laurent, Thanks for the review!! On Wed, Mar 07, 2012 at 12:04:01PM +0100, Laurent Pinchart wrote: > On Tuesday 06 March 2012 18:33:14 Sakari Ailus wrote: > > No longer assume pad number 0 is the source pad of the external entity. Find > > the source pad from the external entity and use it instead. > > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxx> > > Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > (with one comment below) > > > --- > > drivers/media/video/omap3isp/isp.c | 13 ++++++++++++- > > 1 files changed, 12 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/media/video/omap3isp/isp.c > > b/drivers/media/video/omap3isp/isp.c index f54953d..0718b0a 100644 > > --- a/drivers/media/video/omap3isp/isp.c > > +++ b/drivers/media/video/omap3isp/isp.c > > @@ -1744,6 +1744,7 @@ static int isp_register_entities(struct isp_device > > *isp) struct media_entity *input; > > unsigned int flags; > > unsigned int pad; > > + unsigned int i; > > > > sensor = isp_register_subdev_group(isp, subdevs->subdevs); > > if (sensor == NULL) > > @@ -1791,7 +1792,17 @@ static int isp_register_entities(struct isp_device > > *isp) goto done; > > } > > > > - ret = media_entity_create_link(&sensor->entity, 0, input, pad, > > + for (i = 0; i < sensor->entity.num_pads; i++) > > + if (sensor->entity.pads[i].flags & MEDIA_PAD_FL_SOURCE) > > + break; > > While not strictly needed, I find the code easier to read with brackets for > the for statement. It's up to you though. Brackets added. -- Sakari Ailus e-mail: sakari.ailus@xxxxxx jabber/XMPP/Gmail: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
