Re: [RFC PATCH 2/4] v4l: Add V4L2_CID_SCENEMODE menu control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thursday 29 December 2011 06:40:57 HeungJun, Kim wrote:
> On Wednesday, December 28, 2011 10:56 PM Laurent Pinchart wrote:
> > On Wednesday 28 December 2011 07:23:46 HeungJun, Kim wrote:

[snip]

> > > diff --git a/Documentation/DocBook/media/v4l/controls.xml
> > > b/Documentation/DocBook/media/v4l/controls.xml index 350c138..afe1845
> > > 100644
> > > --- a/Documentation/DocBook/media/v4l/controls.xml
> > > +++ b/Documentation/DocBook/media/v4l/controls.xml
> > > @@ -2879,6 +2879,94 @@ it one step further. This is a write-only
> > > control.</entry> </row>
> > > 
> > >  	  <row><entry></entry></row>
> > > 
> > > +	  <row id="v4l2-scenemode">
> > > +	    <entry
> > > spanname="id"><constant>V4L2_CID_SCENEMODE</constant>&nbsp;</entry> +
> > > <entry>enum&nbsp;v4l2_scenemode</entry>
> > > +	  </row><row><entry spanname="descr">This control sets
> > > +	  the camera's scenemode, and it is provided by the type of
> > > +	  the enum values. The "None" mode means the status
> > > +	  when scenemode algorithm is not activated, like after booting
> > > time.
> > > +	  On the other hand, the "Normal" mode means the scenemode algorithm
> > > +	  is activated on the normal mode.</entry>
> > 
> > What low-level parameters do the scene mode control ? How does it
> > interact with the related controls ?
> 
> For using this control, in M-5MOLS sensor case, several register is
> configured, like Exposure(locking/Indexed preset/mode), Focus(locking),
> WhiteBalance, etc. And I think the process interacting and syncing the
> register's value should be up to the each drivers, and the m5mols driver
> will be.

Does it mean that the scene mode is handled by the driver, which then 
configures exposure, focus, white balance, ... ?

> Anyways, could you explain the difference with low- and high- in more
> details?
> 
> :)
> 
> I still did not understand well.

The concepts are a bit ill-defined currently. We have low-level sensor 
controls such as exposure time, gains, ... The controls you propose offer a 
higher level interface, likely using software-based algorithms running on the 
sensor instead of just applying hardware parameters.

> > > +	  </row>
> > > +	  <row>
> > > +	    <entrytbl spanname="descr" cols="2">
> > > +	      <tbody valign="top">
> > > +		<row>
> > > +		  <entry><constant>V4L2_SCENEMODE_NONE</constant>&nbsp;</entry>
> > > +		  <entry>Scenemode None.</entry>
> > > +		</row>
> > > +		<row>
> > > +
> 
> <entry><constant>V4L2_SCENEMODE_NORMAL</constant>&nbsp;</entry>
> 
> > > +		  <entry>Scenemode Normal.</entry>
> > > +		</row>
> > > +		<row>
> > > +
> > 
> > <entry><constant>V4L2_SCENEMODE_PORTRAIT</constant>&nbsp;</entry>
> > 
> > > +		  <entry>Scenemode Portrait.</entry>
> > 
> > Could you please describe the scene modes in more details ?
> 
> Yes, the photographer should adjust the exposure(luminance), focus, iso,
> etc, for getting better image according to each specific circumstances.
> But, it's uncomfortable to set all controls at every time.
> The scene mode can make this at one time. It is just not only setting once.
> According to fixed scene circumstance, the internal algorithm is also
> needed for it.
> 
> This function is usually provided as just preset, but, it's not just
> preset, because the specific algorithm is existed for "scene mode",
> except the collection of the camera control preset.
> 
> The enumeration I suggest, can cover almost scene mode. Of course, the term
> is fixed. The M-5MOLS can use all the scene mode.
> Please, see drivers/media/video/m5mols/m5mols_contro.c.

What I meant when asking you to explain the scene modes in more details was to 
improve the documentation by adding a detailed description of each scene mode.

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux