Re: [RFC PATCH 3/4] v4l: Add V4L2_CID_WDR button control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thursday 29 December 2011 06:52:55 HeungJun, Kim wrote:
> On Wednesday, December 28, 2011 10:57 PM Laurent Pinchart wrote:
> > On Wednesday 28 December 2011 07:23:47 HeungJun, Kim wrote:
> > > It adds the new CID for setting White Balance Preset. This CID is
> > > provided
> > 
> > I suppose you mean wide dynamic range here.
> 
> Right, it's my miss.
> 
> > > as button type. This can commands only if the camera turn on/off this
> > > function.
> > 
> > Shouldn't it be a boolean ? A button can only be activated, for one-shot
> > auto- focus for instance.
> 
> Any type can be possible, and fine to me. But, it depends on the whole
> hardware architecture. The WDR is proceeded and used only in the ISP or
> another engine processing image. And, the cases I've seen ever, are just
> one - The ISP exists in the sensor.
> 
> In M-5MOLS use-case, the ISP is in the M-5MOLS sensor. To the position of
> developer,
> it's just ok to turn on/off for using this. But, in the other architecture
> it might be need more.

You can't turn a button control on or off. A button control can only be 
activated, it has no state. On/off controls are boolean controls.

> But, I anticipate if the other architecture use this function, probably
> any other setting seems be not needed any more. The photographer just says,
> "turn on the WDR!", not says "adjust parm 1, 2, 3, and turn on WDR!". :)
> 
> So, IMHO, I think the any other setting is not needed more for now.

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux