Hi Laurent, > -----Original Message----- > From: linux-media-owner@xxxxxxxxxxxxxxx [mailto:linux-media- > owner@xxxxxxxxxxxxxxx] On Behalf Of Laurent Pinchart > Sent: Wednesday, December 28, 2011 10:56 PM > To: HeungJun, Kim > Cc: linux-media@xxxxxxxxxxxxxxx; mchehab@xxxxxxxxxx; hverkuil@xxxxxxxxx; > sakari.ailus@xxxxxx; s.nawrocki@xxxxxxxxxxx; kyungmin.park@xxxxxxxxxxx > Subject: Re: [RFC PATCH 2/4] v4l: Add V4L2_CID_SCENEMODE menu control > > Hi, > > On Wednesday 28 December 2011 07:23:46 HeungJun, Kim wrote: > > It adds the new CID for setting Scenemode. This CID is provided as > > menu type using the following items: > > enum v4l2_scenemode { > > V4L2_SCENEMODE_NONE = 0, > > V4L2_SCENEMODE_NORMAL = 1, > > V4L2_SCENEMODE_PORTRAIT = 2, > > V4L2_SCENEMODE_LANDSCAPE = 3, > > V4L2_SCENEMODE_SPORTS = 4, > > V4L2_SCENEMODE_PARTY_INDOOR = 5, > > V4L2_SCENEMODE_BEACH_SNOW = 6, > > V4L2_SCENEMODE_SUNSET = 7, > > V4L2_SCENEMODE_DAWN_DUSK = 8, > > V4L2_SCENEMODE_FALL = 9, > > V4L2_SCENEMODE_NIGHT = 10, > > V4L2_SCENEMODE_AGAINST_LIGHT = 11, > > V4L2_SCENEMODE_FIRE = 12, > > V4L2_SCENEMODE_TEXT = 13, > > V4L2_SCENEMODE_CANDLE = 14, > > }; > > > > Signed-off-by: HeungJun, Kim <riverful.kim@xxxxxxxxxxx> > > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > > --- > > Documentation/DocBook/media/v4l/controls.xml | 88 > > ++++++++++++++++++++++++++ drivers/media/video/v4l2-ctrls.c | > > 21 ++++++ > > include/linux/videodev2.h | 19 ++++++ > > 3 files changed, 128 insertions(+), 0 deletions(-) > > > > diff --git a/Documentation/DocBook/media/v4l/controls.xml > > b/Documentation/DocBook/media/v4l/controls.xml index 350c138..afe1845 > > 100644 > > --- a/Documentation/DocBook/media/v4l/controls.xml > > +++ b/Documentation/DocBook/media/v4l/controls.xml > > @@ -2879,6 +2879,94 @@ it one step further. This is a write-only > > control.</entry> </row> > > <row><entry></entry></row> > > > > + <row id="v4l2-scenemode"> > > + <entry > > spanname="id"><constant>V4L2_CID_SCENEMODE</constant> </entry> + > > <entry>enum v4l2_scenemode</entry> > > + </row><row><entry spanname="descr">This control sets > > + the camera's scenemode, and it is provided by the type of > > + the enum values. The "None" mode means the status > > + when scenemode algorithm is not activated, like after booting time. > > + On the other hand, the "Normal" mode means the scenemode algorithm > > + is activated on the normal mode.</entry> > > What low-level parameters do the scene mode control ? How does it interact > with the related controls ? For using this control, in M-5MOLS sensor case, several register is configured, like Exposure(locking/Indexed preset/mode), Focus(locking), WhiteBalance, etc. And I think the process interacting and syncing the register's value should be up to the each drivers, and the m5mols driver will be. Anyways, could you explain the difference with low- and high- in more details? :) I still did not understand well. > > > + </row> > > + <row> > > + <entrytbl spanname="descr" cols="2"> > > + <tbody valign="top"> > > + <row> > > + <entry><constant>V4L2_SCENEMODE_NONE</constant> </entry> > > + <entry>Scenemode None.</entry> > > + </row> > > + <row> > > + <entry><constant>V4L2_SCENEMODE_NORMAL</constant> </entry> > > + <entry>Scenemode Normal.</entry> > > + </row> > > + <row> > > + > <entry><constant>V4L2_SCENEMODE_PORTRAIT</constant> </entry> > > + <entry>Scenemode Portrait.</entry> > > Could you please describe the scene modes in more details ? Yes, the photographer should adjust the exposure(luminance), focus, iso, etc, for getting better image according to each specific circumstances. But, it's uncomfortable to set all controls at every time. The scene mode can make this at one time. It is just not only setting once. According to fixed scene circumstance, the internal algorithm is also needed for it. This function is usually provided as just preset, but, it's not just preset, because the specific algorithm is existed for "scene mode", except the collection of the camera control preset. The enumeration I suggest, can cover almost scene mode. Of course, the term is fixed. The M-5MOLS can use all the scene mode. Please, see drivers/media/video/m5mols/m5mols_contro.c. > > > + </row> > > + <row> > > + > <entry><constant>V4L2_SCENEMODE_LANDSCAPE</constant> </entry> > > + <entry>Scenemode Landscape.</entry> > > + </row> > > + <row> > > + <entry><constant>V4L2_SCENEMODE_SPORTS</constant> </entry> > > + <entry>Scenemode Sports.</entry> > > + </row> > > + <row> > > + > <entry><constant>V4L2_SCENEMODE_PARTY_INDOOR</constant> </entry> > > + <entry>Scenemode Party Indoor.</entry> > > + </row> > > + <row> > > + > <entry><constant>V4L2_SCENEMODE_BEACH_SNOW</constant> </entry> > > + <entry>Scenemode Beach Snow.</entry> > > + </row> > > + <row> > > + <entry><constant>V4L2_SCENEMODE_SUNSET</constant> </entry> > > + <entry>Scenemode Beach Snow.</entry> > > + </row> > > + <row> > > + > <entry><constant>V4L2_SCENEMODE_DAWN_DUSK</constant> </entry> > > + <entry>Scenemode Dawn Dusk.</entry> > > + </row> > > + <row> > > + <entry><constant>V4L2_SCENEMODE_FALL</constant> </entry> > > + <entry>Scenemode Fall.</entry> > > + </row> > > + <row> > > + <entry><constant>V4L2_SCENEMODE_NIGHT</constant> </entry> > > + <entry>Scenemode Night.</entry> > > + </row> > > + <row> > > + > <entry><constant>V4L2_SCENEMODE_AGAINST_LIGHT</constant> </entry> > > + <entry>Scenemode Against Light.</entry> > > + </row> > > + <row> > > + <entry><constant>V4L2_SCENEMODE_FIRE</constant> </entry> > > + <entry>Scenemode Fire.</entry> > > + </row> > > + <row> > > + <entry><constant>V4L2_SCENEMODE_TEXT</constant> </entry> > > + <entry>Scenemode Text.</entry> > > + </row> > > + <row> > > + <entry><constant>V4L2_SCENEMODE_CANDLE</constant> </entry> > > + <entry>Scenemode Candle.</entry> > > + </row> > > + </tbody> > > + </entrytbl> > > + </row> > > + <row><entry></entry></row> > > + > > + <row> > > + <entry > > spanname="id"><constant>V4L2_CID_PRIVACY</constant> </entry> + > > <entry>boolean</entry> > > + </row><row><entry spanname="descr">Prevent video from being acquired > > +by the camera. When this control is set to <constant>TRUE</constant> (1), > > no +image can be captured by the camera. Common means to enforce privacy > > are +mechanical obturation of the sensor and firmware image processing, > > but the +device is not restricted to these methods. Devices that implement > > the privacy +control must support read access and may support write > > access.</entry> + </row> > > <row> > > <entry > > spanname="id"><constant>V4L2_CID_PRIVACY</constant> </entry> > > <entry>boolean</entry> > > -- > Regards, > > Laurent Pinchart > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
