On Tue, Dec 20, 2011 at 05:29:47PM +0800, Scott Jiang wrote: > Hi Sakari, > > Hans recommends me using v4l2_fh_is_singular in first open, but I > found it used list_is_singular(&fh->list). > Should it use &fh->vdev->fh_list or I missed something? Hi, Scott! I think why Hans is telling you that you should use v4l2_fh_is_singular() instead of going for list_is_singular() directly, is that how the file handles are being stored by the V4L2 subdev framework might be changed in the future. If you use v4l2_fh_is_singular(), you won't need to change your driver if that happens. Besides that, it's often better not deal with things you don't really need to. Regards, -- Sakari Ailus e-mail: sakari.ailus@xxxxxx jabber/XMPP/Gmail: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
