2011/7/23 Antti Palosaari <crope@xxxxxx>: > On 07/23/2011 01:47 AM, HoP wrote: >> >> 2011/7/23 Antti Palosaari<crope@xxxxxx>: >>> >>> On 07/23/2011 01:18 AM, HoP wrote: >>>> >>>> In case of i2c write operation there is only one element in msg[] array. >>>> Don't access msg[1] in that case. >>> >>> NACK. >>> I suspect you confuse now local msg2 and msg that is passed as function >>> parameter. Could you double check and explain? >>> >> >> Ok, may I really understand it badly. >> >> My intention was that in case of tda18271_write_regs() there is >> i2c_transfer() called with msg[] array of one element only. >> So am I wrong? > > No. There is only one msg array in write and in case of reg read there is > two elements, first one is write and second is read. > > But now I see what you mean. msg2[1] is set as garbage fields in case of > incoming msg len is 1. True, but it does not harm since it is not used in > that case. In case of write, cxd2820r_tuner_i2c_xfer() gets msg[] parameter with only one element, true? If so, then my patch is correct. > > The idea of whole system is just add 2 bytes to incoming msg .buf and then > forward that message. > Yes. I just learnt it, very clever way. What I only don't understand is why do you decrease msg2[0].len. Seems really like some hw bug. Honza -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
