Re: [PATCH] cxd2820r: fix possible out-of-array lookup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/23/2011 01:47 AM, HoP wrote:
2011/7/23 Antti Palosaari<crope@xxxxxx>:
On 07/23/2011 01:18 AM, HoP wrote:

In case of i2c write operation there is only one element in msg[] array.
Don't access msg[1] in that case.

NACK.
I suspect you confuse now local msg2 and msg that is passed as function
parameter. Could you double check and explain?


Ok, may I really understand it badly.

My intention was that in case of tda18271_write_regs() there is
i2c_transfer() called with msg[] array of one element only.
So am I wrong?

No. There is only one msg array in write and in case of reg read there is two elements, first one is write and second is read.

But now I see what you mean. msg2[1] is set as garbage fields in case of incoming msg len is 1. True, but it does not harm since it is not used in that case.

The idea of whole system is just add 2 bytes to incoming msg .buf and then forward that message.

regards
Antti


Thanks

Honza


--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux