Re: [PATCH] cxd2820r: fix possible out-of-array lookup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/23/2011 01:18 AM, HoP wrote:
In case of i2c write operation there is only one element in msg[] array.
Don't access msg[1] in that case.

NACK.
I suspect you confuse now local msg2 and msg that is passed as function parameter. Could you double check and explain?


regards
Antti


Signed-off-by: Honza Petrous<jpetrous@xxxxxxxxxxx>

--

diff -uBbp cxd2820r_core.c.orig cxd2820r_core.c
--- cxd2820r_core.c.orig	2011-07-22 23:31:56.319168405 +0200
+++ cxd2820r_core.c	2011-07-22 23:35:02.508046078 +0200
@@ -750,8 +750,6 @@ static int cxd2820r_tuner_i2c_xfer(struc
  		}, {
  			.addr = priv->cfg.i2c_address,
  			.flags = I2C_M_RD,
-			.len = msg[1].len,
-			.buf = msg[1].buf,
  		}
  	};

@@ -760,6 +758,8 @@ static int cxd2820r_tuner_i2c_xfer(struc
  	if (num == 2) { /* I2C read */
  		obuf[1] = (msg[0].addr<<  1) | I2C_M_RD; /* I2C RD flag */
  		msg2[0].len = sizeof(obuf) - 1; /* maybe HW bug ? */
+		msg2[1].len = msg[1].len;
+		msg2[1].buf = msg[1].buf;
  	}
  	memcpy(&obuf[2], msg[0].buf, msg[0].len);


--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux