Hi Guennadi, On Sun, Jul 17, 2011 at 07:09:42PM +0200, Guennadi Liakhovetski wrote: > On Tue, 12 Jul 2011, Michael Grzeschik wrote: > > > added new bit offset defines, > > more supported BE colour formats > > and also support BGR565 swapped pixel formats > > > > removed pixfmt helper functions and option flags > > setting the configuration register directly in set_pixfmt > > > > added reg_mask function > > > > reg_mask is basically the same as clearing & setting registers, > > but it is more convenient and faster (saves one rw cycle). > > > > Signed-off-by: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx> > > Signed-off-by: Philipp Wiesner <p.wiesner@xxxxxxxxx> > > Applied after pretty heavy modifications. (1) forward-ported to the > current tree, (2) removed Bayer swapping, as discussed earlier, (3) > removed double bitfield definitions. Please, check out > > http://git.linuxtv.org/gliakhovetski/v4l-dvb.git?a=shortlog;h=refs/heads/for-3.1 > > and see, if I haven't inadvertently broken anything. I double checked all modifications and also tested your patch with some formats. I also prefer the idea to handle the configuration of data_outfmt1 in a separete patch. So everything looks right to me. Thanks, Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html