Hi Michael,
There's no need to set initial return values to zero if they're assigned to in
all code paths.
[snip]
> *client) static int mt9m111_enable(struct i2c_client *client)
> {
> struct mt9m111 *mt9m111 = to_mt9m111(client);
> - int ret;
> + int ret = 0;
>
> ret = reg_set(RESET, MT9M111_RESET_CHIP_ENABLE);
> if (!ret)
This is a clear example, ret will never be used uninitialized. Initializing it
to 0 would be a waste of resources (although in this case it will probably be
optimized out by the compiler).
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
