Re: Sveon stv22 patches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello
Comments below.

Could you use Git since you have latest Kernel? If that's too hard don't try it, I can leave without, but it will easy my work a little.

You have diffed wrong direction, those patches are removing lines rather than adding (- vs. +). Also you your signed off by is needed.
See:
http://linuxtv.org/wiki/index.php/Development:_Submitting_Patches

--- ./rc-map.h	2011-06-21 11:16:55.000000000 +0200
+++ ./include/media/rc-map.h	2011-06-21 12:41:34.114509214 +0200
@@ -130,7 +130,6 @@
  #define RC_MAP_RC6_MCE                   "rc-rc6-mce"
  #define RC_MAP_REAL_AUDIO_220_32_KEYS    "rc-real-audio-220-32-keys"
  #define RC_MAP_STREAMZAP                 "rc-streamzap"
-#define RC_MAP_SVEON_STV22		 "rc-msi-digivox-iii"
  #define RC_MAP_TBS_NEC                   "rc-tbs-nec"
  #define RC_MAP_TECHNISAT_USB2            "rc-technisat-usb2"
  #define RC_MAP_TERRATEC_CINERGY_XS       "rc-terratec-cinergy-xs"

That's wrong, it is not needed at all. All the other seems to be rather OK.

regards
Antti

--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux