Re: [PATCH 2/4 v9] v4l: add control definitions for codec devices.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday, June 22, 2011 12:30:45 Kamil Debski wrote:
> > > +	      <row>
> > > +		<entry
> > spanname="id"><constant>V4L2_CID_MPEG_VIDEO_MPEG4_VOP_TIME_RES</constant>&nb
> > sp;</entry>
> > > +		<entry>integer</entry>
> > > +	      </row><row><entry spanname="descr">vop_time_increment_resolution
> > value for MPEG4. Applicable to the MPEG4 encoder.</entry>
> > > +	      </row>
> > > +	      <row><entry></entry></row>
> > > +	      <row>
> > > +		<entry
> > spanname="id"><constant>V4L2_CID_MPEG_VIDEO_MPEG4_VOP_TIME_INC</constant>&nb
> > sp;</entry>
> > > +		<entry>integer</entry>
> > > +	      </row><row><entry spanname="descr">vop_time_increment value for
> > MPEG4. Applicable to the MPEG4 encoder.</entry>
> > 
> > How should these two controls be used? Are you supposed to set them? Or do
> > they
> > have suitable default values?
> 
> They are used only in MPEG4 and are used instead of S_PARM to set fps.
> You are supposed to set them, but I think the driver could set a default value
> (such as vop_time_res = 30000 and vop_time_res_increment = 1000).

Hmm. Perhaps S_PARM should be used for this? I am not too keen on adding this
when it looks like it is exactly the same as the S_PARM functionality.

How do other codecs do this?

> > > +
> > <entry><constant>V4L2_MPEG_MFC51_FRAME_SKIP_MODE_DISABLED</constant>&nbsp;</
> > entry>
> > > +		      <entry>Frame skip mode is disabled.</entry>
> > > +		    </row>
> > > +		    <row>
> > > +
> > <entry><constant>V4L2_MPEG_MFC51_FRAME_SKIP_MODE_LEVEL_LIMIT</constant>&nbsp
> > ;</entry>
> > > +		      <entry>Frame skip mode enabled and buffer limit is set by
> > the chosen level.</entry>
> > 
> > With which control do I set that level?
> 
> *_MPEG4_LEVEL and *_H264_LEVEL, I will add some clarification.

Ah! That level :-)

Regards,

	Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux