Hi, Just a quick comment below. > -----Original Message----- > From: Hans Verkuil [mailto:hverkuil@xxxxxxxxx] > Sent: 22 June 2011 10:26 > > On Tuesday, June 14, 2011 18:36:54 Kamil Debski wrote: > > Add control definitions and documentation for controls > > specific to codec devices. > > > > Signed-off-by: Kamil Debski <k.debski@xxxxxxxxxxx> > > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > > --- > > Documentation/DocBook/media/v4l/controls.xml | 958 > ++++++++++++++++++++++++++ > > include/linux/videodev2.h | 171 +++++ > > 2 files changed, 1129 insertions(+), 0 deletions(-) > > > > diff --git a/Documentation/DocBook/media/v4l/controls.xml > b/Documentation/DocBook/media/v4l/controls.xml > > index 6880798..6b0d06a 100644 > > --- a/Documentation/DocBook/media/v4l/controls.xml > > +++ b/Documentation/DocBook/media/v4l/controls.xml > > @@ -325,6 +325,22 @@ minimum value disables backlight ... > > + <row><entry></entry></row> > > + <row> > > + <entry > spanname="id"><constant>V4L2_CID_MPEG_VIDEO_MB_RC_ENABLE</constant> </e > ntry> > > + <entry>boolean</entry> > > + </row> > > + <row><entry spanname="descr">Macroblock level rate control > enable. > > +Applicable to the MPEG4 and H264 encoders.</entry> > > If I understand this right enabling this will 'activate' the > V4L2_CID_MPEG_MFC51_VIDEO_H264_ADAPTIVE_RC_* controls. > > So this makes me wonder whether this control shouldn't perhaps be MFC51 > specific > as well. Alternatively, we can say something like: 'How macroblock rate > control is > implemented will differ per device, so devices that implement this will have > their > own set of controls.' > The V4L2_CID_MPEG_MFC51_VIDEO_H264_ADAPTIVE_RC_* controls are an added tweak by MFC. So I think it should stay as a generic control, especially that macroblock rate control is defined in the MPEG4 standard. ... Best regards, -- Kamil Debski Linux Platform Group Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
