On Thursday 02 June 2011 11:46:15 Lutz Sammer wrote: > Hello Hans Petter, Hi, > > I haven't tested your patch yet, but looking at the source I see some > problems. > > What does your patch fix and how? It switches from software derot to hardware derot, by writing zero to the derot register. > > If you have problem locking channels, try my locking patch: > https://patchwork.kernel.org/patch/753382/ > > On each step (timing, carrier, data) you reset the derot: > stb0899_set_derot(state, 0); > Why? I have no good reason. It just works. > > Afaik you destroy already locked frequencies, which slows > down the locking. > > Than you do 8 loops: > for (index = 0; index < 8; index++) { > Why? > > All checks already contains some delays, if the delays are too > short, you should fix this delays. I can test patches regarding channel locking. The initial problem was the the stb0899 driver would not tune any channels. --HPS -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
