RE: [PATCH v3 - resend] Fix the derot zig-zag to work with TT-USB2.0 TechnoTrend.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Hans Petter,

I haven't tested your patch yet, but looking at the source I see some
problems.

What does your patch fix and how?

If you have problem locking channels, try my locking patch:
https://patchwork.kernel.org/patch/753382/

On each step (timing, carrier, data) you reset the derot:
     stb0899_set_derot(state, 0);
Why?

Afaik you destroy already locked frequencies, which slows
down the locking.

Than you do 8 loops:
    for (index = 0; index < 8; index++) {
Why?

All checks already contains some delays, if the delays are too
short, you should fix this delays.

Johns
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux