On Thu, 2 Jun 2011, Jonathan Corbet wrote: > On Wed, 1 Jun 2011 21:16:45 +0800 > Kassey Lee <ygli@xxxxxxxxxxx> wrote: > > > This driver exports a video device node per each CCIC > > (CMOS Camera Interface Controller) > > device contained in Marvell Mobile PXA910 SoC > > The driver is based on soc-camera + videobuf2 frame > > work, and only USERPTR is supported. > > This device looks awfully similar to the Cafe controller; you must > certainly have known that, since some of the code in your driver is > clearly copied (without attribution) from cafe_ccic.c. Yes, I noticed this, as I saw the cafe_ccic header being included in this driver. > As it happens, I've just written a driver for the Armada 610 SoC found > in the OLPC 1.75 system; I was planning to post it as early as next > week. I took a different approach, though: rather than duplicating the > Cafe code, I split that driver into core and platform parts, then added > a new platform piece for the Armada 610. I do believe that is a better > way of doing things. > > That said, your driver has useful stuff that mine doesn't - MIPI > support, for example. > > I'm traveling, but will be back next week. I'll send out my work after > that; then I would really like to find a way to make all these pieces > work together with a common core for cafe-derived controllers. Make > sense? This is definitely the right direction! Thanks for your heads-up! Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
