On 10/01/2025 10:29, Sakari Ailus wrote:
Hi Bryan,
On Fri, Jan 10, 2025 at 10:23:40AM +0000, Bryan O'Donoghue wrote:
On 10/01/2025 08:43, Hans de Goede wrote:
Hi,
On 10-Jan-25 8:21 AM, Sakari Ailus wrote:
Hi Hans,
On Thu, Jan 09, 2025 at 10:23:41PM +0100, Hans de Goede wrote:
Hi,
On 9-Jan-25 5:37 PM, Sakari Ailus wrote:
Hi Hans,
On Fri, Dec 20, 2024 at 03:41:28PM +0100, Hans de Goede wrote:
The driver might skip the ov08x40_identify_module() on probe() based on
the acpi_dev_state_d0() check done in probe().
If the ov08x40_identify_module() call is skipped on probe() it should
be done on the first stream start. Add the missing call.
Note ov08x40_identify_module() will only do something on its first call,
subsequent calls are no-ops.
Tested-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
I'll add:
Fixes: b1a42fde6e07 ("media: ov08x40: Avoid sensor probing in D0 state")
Cc: stable@xxxxxxxxxxxxxxx
Sounds good, thank you.
That is when you say "I'll add", you mean you'll add those tags
while merging this series, right ?
Or do you want me to the tags in a v3 series?
No need for v3. Thanks!
Are there other patches not merged for the driver, besides this set? No?
Bryan was talking about a fix from him which also needs to be merged:
https://git.codelinaro.org/bryan.odonoghue/kernel/-/commit/f10539a3cbe5c072829b082683f0d1393a7e50dc
But I cannot find that in the lore archives.
Bryan, did you ever post that fix ?
Regards,
Hans
Yep, it would be nice to place that patch first as patch #3 in this series
conflicts with it.
I've fixed up the tree here:
https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/media-stage/master-ov08x40-integration?ref_type=heads
Hans's patches are in my tree already. Could you rebase yours on my devel
branch (tree at <URL:https://git.linuxtv.org/sailus/media_tree.git/>) and
post it?
https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/media-sailus/devel-ov08x40?ref_type=heads
Puts
https://git.codelinaro.org/bryan.odonoghue/kernel/-/commit/b8f7e192b6bf0b8859158fb2b28b479d5c389054
before
https://git.codelinaro.org/bryan.odonoghue/kernel/-/commit/9370a82094d47d0383b0d52681b6b3a8d711ef9e
So that the first patch can be applied to stable.
---
bod
