Re: [PATCH v2 08/10] media: ov08x40: Add missing ov08x40_identify_module() call on stream-start

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 10-Jan-25 8:21 AM, Sakari Ailus wrote:
> Hi Hans,
> 
> On Thu, Jan 09, 2025 at 10:23:41PM +0100, Hans de Goede wrote:
>> Hi,
>>
>> On 9-Jan-25 5:37 PM, Sakari Ailus wrote:
>>> Hi Hans,
>>>
>>> On Fri, Dec 20, 2024 at 03:41:28PM +0100, Hans de Goede wrote:
>>>> The driver might skip the ov08x40_identify_module() on probe() based on
>>>> the acpi_dev_state_d0() check done in probe().
>>>>
>>>> If the ov08x40_identify_module() call is skipped on probe() it should
>>>> be done on the first stream start. Add the missing call.
>>>>
>>>> Note ov08x40_identify_module() will only do something on its first call,
>>>> subsequent calls are no-ops.
>>>>
>>>> Tested-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
>>>> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
>>>
>>> I'll add:
>>>
>>> Fixes: b1a42fde6e07 ("media: ov08x40: Avoid sensor probing in D0 state")
>>> Cc: stable@xxxxxxxxxxxxxxx
>>
>> Sounds good, thank you.
>>
>> That is when you say "I'll add", you mean you'll add those tags
>> while merging this series, right ?
>>
>> Or do you want me to the tags in a v3 series?
> 
> No need for v3. Thanks!
> 
> Are there other patches not merged for the driver, besides this set? No?

Bryan was talking about a fix from him which also needs to be merged:

https://git.codelinaro.org/bryan.odonoghue/kernel/-/commit/f10539a3cbe5c072829b082683f0d1393a7e50dc

But I cannot find that in the lore archives.

Bryan, did you ever post that fix ?

Regards,

Hans






[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux