Hi,
On 9-Jan-25 5:37 PM, Sakari Ailus wrote:
> Hi Hans,
>
> On Fri, Dec 20, 2024 at 03:41:28PM +0100, Hans de Goede wrote:
>> The driver might skip the ov08x40_identify_module() on probe() based on
>> the acpi_dev_state_d0() check done in probe().
>>
>> If the ov08x40_identify_module() call is skipped on probe() it should
>> be done on the first stream start. Add the missing call.
>>
>> Note ov08x40_identify_module() will only do something on its first call,
>> subsequent calls are no-ops.
>>
>> Tested-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
>> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
>
> I'll add:
>
> Fixes: b1a42fde6e07 ("media: ov08x40: Avoid sensor probing in D0 state")
> Cc: stable@xxxxxxxxxxxxxxx
Sounds good, thank you.
That is when you say "I'll add", you mean you'll add those tags
while merging this series, right ?
Or do you want me to the tags in a v3 series?
Regards,
Hans
>
>> ---
>> drivers/media/i2c/ov08x40.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/media/i2c/ov08x40.c b/drivers/media/i2c/ov08x40.c
>> index 39430528f54f..7d00740222c1 100644
>> --- a/drivers/media/i2c/ov08x40.c
>> +++ b/drivers/media/i2c/ov08x40.c
>> @@ -1973,6 +1973,10 @@ static int ov08x40_set_stream(struct v4l2_subdev *sd, int enable)
>> if (ret < 0)
>> goto err_unlock;
>>
>> + ret = ov08x40_identify_module(ov08x);
>> + if (ret)
>> + goto err_rpm_put;
>> +
>> /*
>> * Apply default & customized values
>> * and then start streaming.
>
