Hi Ricardo, Thank you for the patch. On Wed, Dec 18, 2024 at 09:39:09PM +0000, Ricardo Ribalda wrote: > The module param `nodrop` defines what to do with frames that contain an > error: drop them or sending them to userspace. > > The default in the rest of the media subsystem is to return buffers with > an error to userspace with V4L2_BUF_FLAG_ERROR set in v4l2_buffer.flags. > In UVC we drop buffers with errors by default. > > Change the default behaviour of uvcvideo to match the rest of the > drivers and maybe get rid of the module parameter in the future. > > Suggested-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > drivers/media/usb/uvc/uvc_driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c > index b3c8411dc05c..091145743872 100644 > --- a/drivers/media/usb/uvc/uvc_driver.c > +++ b/drivers/media/usb/uvc/uvc_driver.c > @@ -32,7 +32,7 @@ > > unsigned int uvc_clock_param = CLOCK_MONOTONIC; > unsigned int uvc_hw_timestamps_param; > -unsigned int uvc_no_drop_param; > +unsigned int uvc_no_drop_param = 1; > static unsigned int uvc_quirks_param = -1; > unsigned int uvc_dbg_param; > unsigned int uvc_timeout_param = UVC_CTRL_STREAMING_TIMEOUT; -- Regards, Laurent Pinchart
