We intend to deprecate the nodrop parameter in the future and adopt the default behaviour of the other media drivers: return buffers with an error to userspace with V4L2_BUF_FLAG_ERROR set in v4l2_buffer.flags. Make the first step in the deprecation by changing the default value of the parameter and printing an error message when the value is changed. While implementing this change, Hans found an error in uvc_queue_buffer_complete(). This series also fix it. Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx> --- Changes in v2: - Improve cover letter wording. - Add new patch to fix vb2_buffer_done() - Link to v1: https://lore.kernel.org/r/20241217-uvc-deprecate-v1-0-57d353f68f8f@xxxxxxxxxxxx --- Ricardo Ribalda (4): media: uvcvideo: Propagate buf->error to userspace media: uvcvideo: Invert default value for nodrop module param media: uvcvideo: Allow changing noparam on the fly media: uvcvideo: Announce the user our deprecation intentions drivers/media/usb/uvc/uvc_driver.c | 23 ++++++++++++++++++++--- drivers/media/usb/uvc/uvc_queue.c | 9 ++++----- drivers/media/usb/uvc/uvcvideo.h | 4 +--- 3 files changed, 25 insertions(+), 11 deletions(-) --- base-commit: d216d9cb4dd854ef0a2ec1701f403facb298af51 change-id: 20241217-uvc-deprecate-fbd6228fa1e2 Best regards, -- Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
