Hi Ricardo, Thank you for the patch. On Wed, Dec 18, 2024 at 09:39:08PM +0000, Ricardo Ribalda wrote: > Now we return VB2_BUF_STATE_DONE for valid and invalid frames. Propagate > the correct value, so the user can know if the frame is valid or not via > struct v4l2_buffer->flags. > > Reported-by: Hans de Goede <hdegoede@xxxxxxxxxx> > Closes: https://lore.kernel.org/linux-media/84b0f212-cd88-46bb-8e6f-b94ec3eccba6@xxxxxxxxxx > Fixes: 6998b6fb4b1c ("[media] uvcvideo: Use videobuf2-vmalloc") > Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > drivers/media/usb/uvc/uvc_queue.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/usb/uvc/uvc_queue.c b/drivers/media/usb/uvc/uvc_queue.c > index 26ee85657fc8..f8464f0aae1b 100644 > --- a/drivers/media/usb/uvc/uvc_queue.c > +++ b/drivers/media/usb/uvc/uvc_queue.c > @@ -479,7 +479,8 @@ static void uvc_queue_buffer_complete(struct kref *ref) > > buf->state = buf->error ? UVC_BUF_STATE_ERROR : UVC_BUF_STATE_DONE; > vb2_set_plane_payload(&buf->buf.vb2_buf, 0, buf->bytesused); > - vb2_buffer_done(&buf->buf.vb2_buf, VB2_BUF_STATE_DONE); > + vb2_buffer_done(&buf->buf.vb2_buf, buf->error ? VB2_BUF_STATE_ERROR : > + VB2_BUF_STATE_DONE); > } > > /* -- Regards, Laurent Pinchart
