On 29/10/2024 14:36, Mirela Rabulea wrote: >> >> Binding also looks very different than all other devices, so re-write it >> starting from EXISTING GOOD bindings. Not some downstream stuff. > Would this be a good example? > Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml Yes, looks good. >> >> A nit, subject: drop second/last, redundant "bindings". The >> "dt-bindings" prefix is already stating that these are bindings. >> See also: >> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 >> >> A nit, subject: drop second/last "driver". Bindings are for hardware, >> not drivers. > Please correct the example so it matches coding style. Just compare how your DTS and imx DTS look like. Best regards, Krzysztof
