Hi Krzysztof,
thanks for feedback.
On 29.10.2024 08:14, Krzysztof Kozlowski wrote:
On 28/10/2024 20:06, Mirela Rabulea wrote:
Add bindings for OX05B1S sensor driver
Signed-off-by: Mirela Rabulea <mirela.rabulea@xxxxxxx>
<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.
My bad, I ran get_maintainer.pl on the driver, but forgot to do so for
the bindings. I will resend to extended audience, once I will also
address the feedback from all reviewers.
Please kindly resend and include all necessary To/Cc entries.
</form letter>
Binding also looks very different than all other devices, so re-write it
starting from EXISTING GOOD bindings. Not some downstream stuff.
Would this be a good example?
Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml
A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
A nit, subject: drop second/last "driver". Bindings are for hardware,
not drivers.
I will rephrase it to:
dt-bindings: media: i2c: Add OX05B1S sensor
Add bindings for OX05B1S sensor.
Thanks,
Mirela
Best regards,
Krzysztof
