On 27/09/2024 01:31, Bryan O'Donoghue wrote: > On 26/09/2024 16:53, Sakari Ailus wrote: >>> + - const: xvclk >> This seems redundant. > > Right so you're saying you'd prefer something like this > > drivers/media/i2c/ov8865.c > > I can drop the dependency on "xvclk" as a dependency in this series. Not sure what do you mean here. Drop the clock-names and clock-frequency. Both are redundant. You should almost never have a clock-frequency in your device bindings. Best regards, Krzysztof