Hi,
On 12/09/2010 01:08 PM, Jean-Francois Moine wrote:
On Wed, 08 Dec 2010 14:06:06 -0200
Mauro Carvalho Chehab<mchehab@xxxxxxxxxx> wrote:
Drivers should provide a wmaxpacketsize range which they need / can
deal with for a given resolution. This way we can fix your does not
need highest alt setting at lower resolutions scenario (which is a
very valid one), while still allowing fallback to a lower alt
setting if the driver can deal with lower settings too, be it by
lowering framerate or by increasing compression (decreasing the
image quality).
It seems a good strategy.
Hi,
That seems fine also to me.
p.s.
If you look at my recent stv06xx changes you will see that this
(having an allowable maxpacketsize per resolution) is already used
there. You could use this to model more generic code for this after.
Also, as a quicker hack, the 'audio' flag could be set only when USB is
1.1. Could that fix the problems found with sn9c20x and stv06xx?
That won't help for the stv06xx, more over the skipping of the alt
currently happens each time alt_xfer gets called. So lets say
we have a came with alt 0-8, before the whole audio hack patch
gspca_main would try:
8, 7, 6, ...
Now it will try:
7, 5, 3, ...
As it skips one alt because of the audio hack each time it tries another
alt setting.
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
