Hi Hans, On 12/01/2010 05:52 PM, Hans Verkuil wrote: > >> Add I2C/V4L2 subdev driver for Siliconfile NOON010PC30 CIF camera. >> The driver implements basic functionality, i.e. CIF/QCIF/QQCIF >> resolution and color format selection, automatic/manual color >> balance control. Other functions like cropping, rotation/flip, >> exposure etc. can be easily implemented if needed. > > Not a full review, but one thing sprang out to me: you should implement > controls using the control framework. See > Documentation/video4linux/v4l2-controls.txt. All new drivers should use > this. It should simplify your code quite a bit. Thank you for taking a look at the patches. I went through the documentation of v4l2-controls and it makes quite a good impression. I've seen the control framework used in some driver before but it seemed a bit complicated at the first sight so I picked the other option, given relatively low number of controls in the driver. Now I see the new controls API is quite a bit an improvement. So I will give it a try, let's see how many lines will get dropped from the original patch ;) Will eventually have to convert also the host driver for the inheritance feature to work. Regards, Sylwester > > Regards, > > Hans > > -- Sylwester Nawrocki Linux Platform Group Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
