> Add I2C/V4L2 subdev driver for Siliconfile NOON010PC30 CIF camera.
> The driver implements basic functionality, i.e. CIF/QCIF/QQCIF
> resolution and color format selection, automatic/manual color
> balance control. Other functions like cropping, rotation/flip,
> exposure etc. can be easily implemented if needed.
Not a full review, but one thing sprang out to me: you should implement
controls using the control framework. See
Documentation/video4linux/v4l2-controls.txt. All new drivers should use
this. It should simplify your code quite a bit.
Regards,
Hans
--
Hans Verkuil - video4linux developer - sponsored by Cisco
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
