Re: [PATCH] media: i2c: ov01a10: Switch back to use struct i2c_driver::probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 20, 2023 at 11:27:51AM +0200, Hans Verkuil wrote:
> On 20/07/2023 11:02, Uwe Kleine-König wrote:
> > Hello,
> > 
> > On Mon, Jun 26, 2023 at 11:05:33AM +0200, Uwe Kleine-König wrote:
> >> struct i2c_driver::probe_new is about to go away. Switch the driver to
> >> use the probe callback with the same prototype.
> >>
> >> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> >> ---
> >>  drivers/media/i2c/ov01a10.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/media/i2c/ov01a10.c b/drivers/media/i2c/ov01a10.c
> >> index de5bc19e715b..2b9e1b3a3bf4 100644
> >> --- a/drivers/media/i2c/ov01a10.c
> >> +++ b/drivers/media/i2c/ov01a10.c
> >> @@ -992,7 +992,7 @@ static struct i2c_driver ov01a10_i2c_driver = {
> >>  		.pm = &ov01a10_pm_ops,
> >>  		.acpi_match_table = ACPI_PTR(ov01a10_acpi_ids),
> >>  	},
> >> -	.probe_new = ov01a10_probe,
> >> +	.probe = ov01a10_probe,
> >>  	.remove = ov01a10_remove,
> >>  };
> > 
> > I plan to ask Wolfram to merge a patch into i2c-next dropping .probe_new
> > for v6.7-rc1. I want to get this early into next after v6.6-rc1, so it
> > would be great to get this patch in before v6.6-rc1.
> > 
> > If this won't happen, the backup plan is to send this patch together
> > with the change of i2c_driver for Wolfram to merge via the i2c tree.
> > 
> > Is this patch still (or at all) on someone's radar for merging?
> 
> I merged this yesterday in our staging tree for 6.6. Did you get an email
> from patchwork?
> 
> https://patchwork.linuxtv.org/project/linux-media/patch/20230626090533.556406-1-u.kleine-koenig@xxxxxxxxxxxxxx/
> 
> I also merged yesterday your patch converting three more drivers:
> 
> https://patchwork.linuxtv.org/project/linux-media/patch/20230718204541.3955386-1-u.kleine-koenig@xxxxxxxxxxxxxx/

Indeed I got a mail about that, but missed that here. (Too many patches
in float here, so I usually check the submission thread and next before
asking about the status. For me it would be a useful improvement if the
mail would be sent in reply to the respecitve mailing list thread.)
 
Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux