Hi Jack, kernel test robot noticed the following build warnings: [auto build test WARNING on media-tree/master] [also build test WARNING on robh/for-next linus/master v6.4-rc7 next-20230621] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jack-Zhu/media-dt-bindings-Add-JH7110-Camera-Subsystem/20230619-193105 base: git://linuxtv.org/media_tree.git master patch link: https://lore.kernel.org/r/20230619112838.19797-6-jack.zhu%40starfivetech.com patch subject: [PATCH v7 5/6] media: starfive: camss: Add ISP driver config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230622/202306221112.MnLtMzRo-lkp@xxxxxxxxx/config) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce: (https://download.01.org/0day-ci/archive/20230622/202306221112.MnLtMzRo-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202306221112.MnLtMzRo-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> drivers/media/platform/starfive/camss/stf_camss.c:173:13: warning: variable 'pad_num' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] } else if (port == STF_PORT_DVP) { ^~~~~~~~~~~~~~~~~~~~ drivers/media/platform/starfive/camss/stf_camss.c:178:18: note: uninitialized use occurs here for (i = 0; i < pad_num; ++i) { ^~~~~~~ drivers/media/platform/starfive/camss/stf_camss.c:173:9: note: remove the 'if' if its condition is always true } else if (port == STF_PORT_DVP) { ^~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/starfive/camss/stf_camss.c:168:25: note: initialize the variable 'pad_num' to silence this warning unsigned int i, pad_num; ^ = 0 1 warning generated. -- >> drivers/media/platform/starfive/camss/stf_isp.c:113:13: warning: variable 'formats' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] } else if (pad == STF_ISP_PAD_SRC) { ^~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/starfive/camss/stf_isp.c:127:18: note: uninitialized use occurs here for (i = 0; i < formats->nfmts; i++) { ^~~~~~~ drivers/media/platform/starfive/camss/stf_isp.c:113:9: note: remove the 'if' if its condition is always true } else if (pad == STF_ISP_PAD_SRC) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/starfive/camss/stf_isp.c:105:40: note: initialize the variable 'formats' to silence this warning const struct isp_format_table *formats; ^ = NULL 1 warning generated. vim +173 drivers/media/platform/starfive/camss/stf_camss.c 156 157 static int stfcamss_subdev_notifier_bound(struct v4l2_async_notifier *async, 158 struct v4l2_subdev *subdev, 159 struct v4l2_async_subdev *asd) 160 { 161 struct stfcamss *stfcamss = 162 container_of(async, struct stfcamss, notifier); 163 struct stfcamss_async_subdev *csd = 164 container_of(asd, struct stfcamss_async_subdev, asd); 165 enum stf_port_num port = csd->port; 166 struct stf_isp_dev *isp_dev = &stfcamss->isp_dev; 167 struct media_pad *pad[STF_PADS_NUM]; 168 unsigned int i, pad_num; 169 170 if (port == STF_PORT_CSI2RX) { 171 pad[0] = &isp_dev->pads[STF_PAD_SINK]; 172 pad_num = 1; > 173 } else if (port == STF_PORT_DVP) { 174 dev_err(stfcamss->dev, "Not support DVP sensor\n"); 175 return -EPERM; 176 } 177 178 for (i = 0; i < pad_num; ++i) { 179 int ret; 180 181 ret = v4l2_create_fwnode_links_to_pad(subdev, pad[i], 0); 182 if (ret < 0) 183 return ret; 184 } 185 186 return 0; 187 } 188 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
