Re: [PATCH v14 17/18] media: i2c: ds90ub953: Restructure clkout management

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 16/06/2023 17:37, Andy Shevchenko wrote:
On Fri, Jun 16, 2023 at 04:59:21PM +0300, Tomi Valkeinen wrote:
Separate clkout calculations and register writes into two functions:
ub953_calc_clkout_params and ub953_write_clkout_regs, and add a struct
ub953_clkout_data that is used to store the clkout parameters.

...

+struct ub953_clkout_data {
+	u32 hs_div;
+	u32 m;
+	u32 n;

Please, use struxt u32_fract instead of m/n.

I'm not sure how that helps. The documentation talks about m and n. Using different terms will make it more difficult to compare the code and the docs.

 Tomi




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux