Re: [PATCH v15 1/2] drm: Add kms driver for loongson display controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 19, 2023 at 6:07 PM Sui Jingfeng <suijingfeng@xxxxxxxxxxx> wrote:
>
> Hi,
>
>
> On 2023/6/19 17:18, Huacai Chen wrote:
> > This patch is too large to review, lsdc_benchmark.c, lsdc_benchmark.h
> > and their call sites can be split to a separate patch.
>
> Better not, large is not a problem.
My review was rejected by the maillist, this is a very big problem.

>
> Single patch is more easy to manage.
>
> The first patch of this driver should comes a whole.
Benchmarks and debugfs are not the very basic parts.

Huacai
>
> --
> Jingfeng
>




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux