Re: [PATCH v3 1/1] media: pci: ipu3-cio2: Obtain remote pad from endpoint

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Laurent,

On Fri, Jun 02, 2023 at 05:23:03PM +0300, Laurent Pinchart wrote:
> Hi Sakari,
> 
> On Fri, Jun 02, 2023 at 02:14:08PM +0000, Sakari Ailus wrote:
> > On Fri, Jun 02, 2023 at 12:12:12PM +0300, Laurent Pinchart wrote:
> > > On Mon, May 15, 2023 at 03:21:27PM +0300, Sakari Ailus wrote:
> > > > Use the endpoint fwnode to find out the remote pad, instead of using the
> > > > first source pad found. Also improve error messages.
> > > 
> > > The commit message should explain *why*. Once I know why, I'll review
> > > the patch :-)
> > 
> > I thought it'd be trivial. :-)
> 
> It may appear trivial as a patch author, but reviewers don't have the
> context, so they shouldn't be expected to guess the intent.

This is actually already in the stage tree. Let's see what we decide to do
with that one.

-- 
Sakari Ailus



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux