Hi Sakari, On Fri, Jun 02, 2023 at 02:14:08PM +0000, Sakari Ailus wrote: > On Fri, Jun 02, 2023 at 12:12:12PM +0300, Laurent Pinchart wrote: > > On Mon, May 15, 2023 at 03:21:27PM +0300, Sakari Ailus wrote: > > > Use the endpoint fwnode to find out the remote pad, instead of using the > > > first source pad found. Also improve error messages. > > > > The commit message should explain *why*. Once I know why, I'll review > > the patch :-) > > I thought it'd be trivial. :-) It may appear trivial as a patch author, but reviewers don't have the context, so they shouldn't be expected to guess the intent. > Using framework functions instead of open coding this in drivers, and using > the pad related to the endpoint fwnode instead of just the first pad found. > > I'll add this to the commit message. -- Regards, Laurent Pinchart
