Hi Yang,
Thank you for the patch.
On Thu, Sep 15, 2022 at 11:03:16PM +0800, Yang Yingliang wrote:
> In the probe path, dev_err() can be replace with dev_err_probe()
> which will check if error code is -EPROBE_DEFER.
>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/platform/mediatek/mdp/mtk_mdp_comp.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/mediatek/mdp/mtk_mdp_comp.c b/drivers/media/platform/mediatek/mdp/mtk_mdp_comp.c
> index 1e3833f1c9ae..ad5fab2d8bfa 100644
> --- a/drivers/media/platform/mediatek/mdp/mtk_mdp_comp.c
> +++ b/drivers/media/platform/mediatek/mdp/mtk_mdp_comp.c
> @@ -52,9 +52,8 @@ int mtk_mdp_comp_init(struct device *dev, struct device_node *node,
> for (i = 0; i < ARRAY_SIZE(comp->clk); i++) {
> comp->clk[i] = of_clk_get(node, i);
> if (IS_ERR(comp->clk[i])) {
> - if (PTR_ERR(comp->clk[i]) != -EPROBE_DEFER)
> - dev_err(dev, "Failed to get clock\n");
> - ret = PTR_ERR(comp->clk[i]);
> + ret = dev_err_probe(dev, PTR_ERR(comp->clk[i]),
> + "Failed to get clock\n");
> goto put_dev;
> }
>
--
Regards,
Laurent Pinchart
