Hi Yang,
Thank you for the patch.
On Thu, Sep 15, 2022 at 11:03:13PM +0800, Yang Yingliang wrote:
> In the probe path, dev_err() can be replace with dev_err_probe()
> which will check if error code is -EPROBE_DEFER.
>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/i2c/ad5820.c | 18 ++++++------------
> 1 file changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/media/i2c/ad5820.c b/drivers/media/i2c/ad5820.c
> index 516de278cc49..6a7f8ef9db05 100644
> --- a/drivers/media/i2c/ad5820.c
> +++ b/drivers/media/i2c/ad5820.c
> @@ -301,21 +301,15 @@ static int ad5820_probe(struct i2c_client *client,
> return -ENOMEM;
>
> coil->vana = devm_regulator_get(&client->dev, "VANA");
> - if (IS_ERR(coil->vana)) {
> - ret = PTR_ERR(coil->vana);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&client->dev, "could not get regulator for vana\n");
> - return ret;
> - }
> + if (IS_ERR(coil->vana))
> + return dev_err_probe(&client->dev, PTR_ERR(coil->vana),
> + "could not get regulator for vana\n");
>
> coil->enable_gpio = devm_gpiod_get_optional(&client->dev, "enable",
> GPIOD_OUT_LOW);
> - if (IS_ERR(coil->enable_gpio)) {
> - ret = PTR_ERR(coil->enable_gpio);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&client->dev, "could not get enable gpio\n");
> - return ret;
> - }
> + if (IS_ERR(coil->enable_gpio))
> + return dev_err_probe(&client->dev, PTR_ERR(coil->enable_gpio),
> + "could not get enable gpio\n");
>
> mutex_init(&coil->power_lock);
>
--
Regards,
Laurent Pinchart
