Hi Yang,
Thank you for the patch.
On Thu, Sep 15, 2022 at 11:03:15PM +0800, Yang Yingliang wrote:
> In the probe path, dev_err() can be replace with dev_err_probe()
s/replace/replaced/
Same for all the other patches in this series.
> which will check if error code is -EPROBE_DEFER.
>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/i2c/tc358743.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
> index 200841c1f5cf..9197fa0b1bc2 100644
> --- a/drivers/media/i2c/tc358743.c
> +++ b/drivers/media/i2c/tc358743.c
> @@ -1891,12 +1891,9 @@ static int tc358743_probe_of(struct tc358743_state *state)
> int ret;
>
> refclk = devm_clk_get(dev, "refclk");
> - if (IS_ERR(refclk)) {
> - if (PTR_ERR(refclk) != -EPROBE_DEFER)
> - dev_err(dev, "failed to get refclk: %ld\n",
> - PTR_ERR(refclk));
> - return PTR_ERR(refclk);
> - }
> + if (IS_ERR(refclk))
> + return dev_err_probe(dev, PTR_ERR(refclk),
> + "failed to get refclk\n");
>
> ep = of_graph_get_next_endpoint(dev->of_node, NULL);
> if (!ep) {
--
Regards,
Laurent Pinchart
