Hi Yang,
Thank you for the patch.
On Thu, Sep 15, 2022 at 11:03:17PM +0800, Yang Yingliang wrote:
> In the probe path, dev_err() can be replace with dev_err_probe()
> which will check if error code is -EPROBE_DEFER.
>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> ---
> drivers/media/platform/samsung/exynos4-is/media-dev.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/samsung/exynos4-is/media-dev.c b/drivers/media/platform/samsung/exynos4-is/media-dev.c
> index 52b43ea04030..b7977d8da8e5 100644
> --- a/drivers/media/platform/samsung/exynos4-is/media-dev.c
> +++ b/drivers/media/platform/samsung/exynos4-is/media-dev.c
> @@ -1473,9 +1473,7 @@ static int fimc_md_probe(struct platform_device *pdev)
>
> pinctrl = devm_pinctrl_get(dev);
> if (IS_ERR(pinctrl)) {
> - ret = PTR_ERR(pinctrl);
> - if (ret != EPROBE_DEFER)
> - dev_err(dev, "Failed to get pinctrl: %d\n", ret);
> + dev_err_probe(dev, PTR_ERR(pinctrl), "Failed to get pinctrl\n");
You need to set ret here.
> goto err_clk;
> }
>
--
Regards,
Laurent Pinchart
