Hi Paul, On Tue, Jul 19, 2022 at 10:55:06AM +0200, Paul Kocialkowski wrote: > Hi Sakari, > > On Wed 13 Jul 22, 22:25, Sakari Ailus wrote: > > The sun6i-mipi-csi2 and sun6i-a83t-mipi-csi2 drivers depend on the generic > > MIPI D-PHY support. Select it. This fixes a linking problem when either of > > these drivers is enabled and GENERIC_PHY_MIPI_DPHY is disabled. > > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > Looks good to me but I have one question below. > > Reviewed-by: Paul Kocialkowski <paul.kocialkowski@xxxxxxxxxxx> > > Cheers, > > Paul > > > --- > > drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig | 1 + > > drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig b/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig > > index b1712f5873fd9..eb982466abd30 100644 > > --- a/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig > > +++ b/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig > > @@ -8,6 +8,7 @@ config VIDEO_SUN6I_MIPI_CSI2 > > select VIDEO_V4L2_SUBDEV_API > > select V4L2_FWNODE > > select PHY_SUN6I_MIPI_DPHY > > + select GENERIC_PHY_MIPI_DPHY > > Since we select PHY_SUN6I_MIPI_DPHY here which also selects > GENERIC_PHY_MIPI_DPHY, I suppose this is not strictly needed? In that case the symbols won't be present in modpost and that causes a build failure. Thanks for the review. The patch is already merged though. -- Kind regards, Sakari Ailus
