Hi Sakari, On Wed 13 Jul 22, 22:25, Sakari Ailus wrote: > The sun6i-mipi-csi2 and sun6i-a83t-mipi-csi2 drivers depend on the generic > MIPI D-PHY support. Select it. This fixes a linking problem when either of > these drivers is enabled and GENERIC_PHY_MIPI_DPHY is disabled. > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> Looks good to me but I have one question below. Reviewed-by: Paul Kocialkowski <paul.kocialkowski@xxxxxxxxxxx> Cheers, Paul > --- > drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig | 1 + > drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig b/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig > index b1712f5873fd9..eb982466abd30 100644 > --- a/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig > +++ b/drivers/media/platform/sunxi/sun6i-mipi-csi2/Kconfig > @@ -8,6 +8,7 @@ config VIDEO_SUN6I_MIPI_CSI2 > select VIDEO_V4L2_SUBDEV_API > select V4L2_FWNODE > select PHY_SUN6I_MIPI_DPHY > + select GENERIC_PHY_MIPI_DPHY Since we select PHY_SUN6I_MIPI_DPHY here which also selects GENERIC_PHY_MIPI_DPHY, I suppose this is not strictly needed? Still feels like a good idea to have it since the driver does use the generic MIPI D-PHY API. Thanks, Paul > select REGMAP_MMIO > help > Support for the Allwinner A31 MIPI CSI-2 controller, also found on > diff --git a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig > index 5854f8388c92a..789d58ee12ea9 100644 > --- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig > +++ b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig > @@ -8,5 +8,6 @@ config VIDEO_SUN8I_A83T_MIPI_CSI2 > select VIDEO_V4L2_SUBDEV_API > select V4L2_FWNODE > select REGMAP_MMIO > + select GENERIC_PHY_MIPI_DPHY > help > Support for the Allwinner A83T MIPI CSI-2 controller and D-PHY. > -- > 2.30.2 > -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature
