Hi Corentin, On 13/10/2021 20:58, Corentin Labbe wrote: > Hello > > The main change of this serie is to fusion all zoran related modules in > one. > This fixes the load order problem when everything is built-in. > > Regards > > Changes since v1: > - add missing debugfs cleaning > - clean some remaining module_get/put functions which made impossible to > remove the zoran module > - added the two latest patchs Something weird is wrong with this series. I have a DC30, but loading this with: modprobe zr36067 card=3 results in this error message in the kernel log: [ 58.645557] zr36067: module is from the staging directory, the quality is unknown, you have been warned. [ 58.646658] zr36067 0000:03:00.0: Zoran MJPEG board driver version 0.10.1 [ 58.646793] zr36067 0000:03:00.0: Zoran ZR36057 (rev 1), irq: 18, memory: 0xf4000000 [ 58.648821] zr36067 0000:03:00.0: Initializing i2c bus... [ 58.662420] vpx3220 22-0047: vpx3216b found @ 0x8e (DC30[0]) [ 58.737445] zr36067 0000:03:00.0: Fail to get encoder This works before, so why this is now failing is not clear to me. It does work with 'card=0', but I really have a DC30. If I test with 'card=0' then the rmmod issue is now solved. Regards, Hans > > Corentin Labbe (10): > staging: media: zoran: move module parameter checks to zoran_probe > staging: media: zoran: use module_pci_driver > staging: media: zoran: rename debug module parameter > staging: media: zoran: add debugfs > staging: media: zoran: videocode: remove procfs > staging: media: zoran: fusion all modules > staging: media: zoran: remove vidmem > staging: media: zoran: move videodev alloc > staging: media: zoran: move config select on primary kconfig > staging: media: zoran: introduce zoran_i2c_init > > drivers/staging/media/zoran/Kconfig | 46 +-- > drivers/staging/media/zoran/Makefile | 8 +- > drivers/staging/media/zoran/videocodec.c | 68 +---- > drivers/staging/media/zoran/videocodec.h | 6 +- > drivers/staging/media/zoran/zoran.h | 6 +- > drivers/staging/media/zoran/zoran_card.c | 328 ++++++++++++++------- > drivers/staging/media/zoran/zoran_driver.c | 5 +- > drivers/staging/media/zoran/zr36016.c | 24 +- > drivers/staging/media/zoran/zr36016.h | 2 + > drivers/staging/media/zoran/zr36050.c | 21 +- > drivers/staging/media/zoran/zr36050.h | 2 + > drivers/staging/media/zoran/zr36060.c | 21 +- > drivers/staging/media/zoran/zr36060.h | 2 + > 13 files changed, 291 insertions(+), 248 deletions(-) >
