Hi Anil, On Tue, Sep 07, 2021 at 03:16:19PM +0000, Anil Kumar Mamidala wrote: > Hi Sakari, > > Can you please review the patches and provide your valuable feedback. > > Please find the change list w.r.to v1 patch below. > 1. Updated code with the review comments from you for patch v1. > - Add check for firmware size > - Remove hardcoding of MIPI lanes > - Use fwnode_graph_get_endpoint_by_id() API instead of fwnode_graph_get_next_endpoint > 2. Add streaming flag to avoid multiple times calling of stream on/off functionality if already in that state. > 3. Add v4l2_ctrls for setting brightness, saturation, AE metering mode, contrast, gain ctrls. The patches seem fine to me. I was waiting for Rob Herring's ack, but I see he's not cc'd nor is the devicetree list. Could you resend the set, with both cc'd? Thanks. -- Kind regards, Sakari Ailus
