Re: [PATCH v8 08/15] media: amphion: add vpu v4l2 m2m support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ming,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on 9c3a0f285248899dfa81585bc5d5bc9ebdb8fead]

url:    https://github.com/0day-ci/linux/commits/Ming-Qian/amphion-video-decoder-encoder-driver/20210907-175342
base:   9c3a0f285248899dfa81585bc5d5bc9ebdb8fead
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/fc6ae31812624f861c29b263d4215f9d059ddcb6
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Ming-Qian/amphion-video-decoder-encoder-driver/20210907-175342
        git checkout fc6ae31812624f861c29b263d4215f9d059ddcb6
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   drivers/media/platform/amphion/vpu_msgs.c: In function 'vpu_handle_msg':
>> drivers/media/platform/amphion/vpu_msgs.c:314:1: warning: the frame size of 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=]
     314 | }
         | ^
   drivers/media/platform/amphion/vpu_msgs.c: In function 'vpu_inst_run_work':
   drivers/media/platform/amphion/vpu_msgs.c:265:1: warning: the frame size of 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=]
     265 | }
         | ^
--
   drivers/media/platform/amphion/vpu_dbg.c: In function 'vpu_dbg_instance':
>> drivers/media/platform/amphion/vpu_dbg.c:169:83: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 6 has type 'dma_addr_t' {aka 'unsigned int'} [-Wformat=]
     169 |                 num = scnprintf(str, sizeof(str), "stream_buffer = %d / %d, [0x%llx, 0x%llx]\n",
         |                                                                                ~~~^
         |                                                                                   |
         |                                                                                   long long unsigned int
         |                                                                                %x
   ......
     172 |                                 inst->stream_buffer.phys,
         |                                 ~~~~~~~~~~~~~~~~~~~~~~~~                           
         |                                                    |
         |                                                    dma_addr_t {aka unsigned int}
   drivers/media/platform/amphion/vpu_dbg.c:169:91: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 7 has type 'dma_addr_t' {aka 'unsigned int'} [-Wformat=]
     169 |                 num = scnprintf(str, sizeof(str), "stream_buffer = %d / %d, [0x%llx, 0x%llx]\n",
         |                                                                                        ~~~^
         |                                                                                           |
         |                                                                                           long long unsigned int
         |                                                                                        %x
   ......
     173 |                                 inst->stream_buffer.phys + inst->stream_buffer.length);
         |                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~      
         |                                                          |
         |                                                          dma_addr_t {aka unsigned int}
   drivers/media/platform/amphion/vpu_dbg.c: In function 'vpu_dbg_core':
   drivers/media/platform/amphion/vpu_dbg.c:224:67: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'dma_addr_t' {aka 'unsigned int'} [-Wformat=]
     224 |         num = scnprintf(str, sizeof(str), "boot_region  = <0x%08llx, 0x%x>\n",
         |                                                              ~~~~~^
         |                                                                   |
         |                                                                   long long unsigned int
         |                                                              %08x
     225 |                         core->fw.phys, core->fw.length);
         |                         ~~~~~~~~~~~~~                              
         |                                 |
         |                                 dma_addr_t {aka unsigned int}
   drivers/media/platform/amphion/vpu_dbg.c:228:67: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'dma_addr_t' {aka 'unsigned int'} [-Wformat=]
     228 |         num = scnprintf(str, sizeof(str), "rpc_region   = <0x%08llx, 0x%x> used = 0x%x\n",
         |                                                              ~~~~~^
         |                                                                   |
         |                                                                   long long unsigned int
         |                                                              %08x
     229 |                         core->rpc.phys, core->rpc.length, core->rpc.bytesused);
         |                         ~~~~~~~~~~~~~~                             
         |                                  |
         |                                  dma_addr_t {aka unsigned int}
   drivers/media/platform/amphion/vpu_dbg.c:232:67: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'dma_addr_t' {aka 'unsigned int'} [-Wformat=]
     232 |         num = scnprintf(str, sizeof(str), "fwlog_region = <0x%08llx, 0x%x>\n",
         |                                                              ~~~~~^
         |                                                                   |
         |                                                                   long long unsigned int
         |                                                              %08x
     233 |                         core->log.phys, core->log.length);
         |                         ~~~~~~~~~~~~~~                             
         |                                  |
         |                                  dma_addr_t {aka unsigned int}


vim +314 drivers/media/platform/amphion/vpu_msgs.c

f1cf0764ca594c8 Ming Qian 2021-09-07  284  
f1cf0764ca594c8 Ming Qian 2021-09-07  285  static int vpu_handle_msg(struct vpu_core *core)
f1cf0764ca594c8 Ming Qian 2021-09-07  286  {
f1cf0764ca594c8 Ming Qian 2021-09-07  287  	struct vpu_rpc_event pkt;
f1cf0764ca594c8 Ming Qian 2021-09-07  288  	struct vpu_inst *inst;
f1cf0764ca594c8 Ming Qian 2021-09-07  289  	int ret;
f1cf0764ca594c8 Ming Qian 2021-09-07  290  
f1cf0764ca594c8 Ming Qian 2021-09-07  291  	memset(&pkt, 0, sizeof(pkt));
f1cf0764ca594c8 Ming Qian 2021-09-07  292  	while (!vpu_iface_receive_msg(core, &pkt)) {
f1cf0764ca594c8 Ming Qian 2021-09-07  293  		vpu_dbg(LVL_DEBUG, "event index = %d, id = %d, num = %d\n",
f1cf0764ca594c8 Ming Qian 2021-09-07  294  				pkt.hdr.index, pkt.hdr.id, pkt.hdr.num);
f1cf0764ca594c8 Ming Qian 2021-09-07  295  
f1cf0764ca594c8 Ming Qian 2021-09-07  296  		ret = vpu_iface_convert_msg_id(core, pkt.hdr.id);
f1cf0764ca594c8 Ming Qian 2021-09-07  297  		if (ret < 0)
f1cf0764ca594c8 Ming Qian 2021-09-07  298  			continue;
f1cf0764ca594c8 Ming Qian 2021-09-07  299  
f1cf0764ca594c8 Ming Qian 2021-09-07  300  		inst = vpu_core_find_instance(core, pkt.hdr.index);
f1cf0764ca594c8 Ming Qian 2021-09-07  301  		if (inst) {
f1cf0764ca594c8 Ming Qian 2021-09-07  302  			vpu_response_cmd(inst, ret, 0);
f1cf0764ca594c8 Ming Qian 2021-09-07  303  			mutex_lock(&core->cmd_lock);
f1cf0764ca594c8 Ming Qian 2021-09-07  304  			vpu_inst_record_flow(inst, ret);
f1cf0764ca594c8 Ming Qian 2021-09-07  305  			mutex_unlock(&core->cmd_lock);
f1cf0764ca594c8 Ming Qian 2021-09-07  306  
f1cf0764ca594c8 Ming Qian 2021-09-07  307  			vpu_inst_handle_msg(inst, &pkt);
f1cf0764ca594c8 Ming Qian 2021-09-07  308  			vpu_inst_put(inst);
f1cf0764ca594c8 Ming Qian 2021-09-07  309  		}
f1cf0764ca594c8 Ming Qian 2021-09-07  310  		memset(&pkt, 0, sizeof(pkt));
f1cf0764ca594c8 Ming Qian 2021-09-07  311  	}
f1cf0764ca594c8 Ming Qian 2021-09-07  312  
f1cf0764ca594c8 Ming Qian 2021-09-07  313  	return 0;
f1cf0764ca594c8 Ming Qian 2021-09-07 @314  }
f1cf0764ca594c8 Ming Qian 2021-09-07  315  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux