Hi Sakari, Please find my reply inline. Thanks and regards, Anil -----Original Message----- From: sakari.ailus@xxxxxx <sakari.ailus@xxxxxx> Sent: Tuesday, August 10, 2021 8:56 PM To: Anil Kumar Mamidala <amamidal@xxxxxxxxxx> Cc: linux-media@xxxxxxxxxxxxxxx; Naveen Kumar Gaddipati <naveenku@xxxxxxxxxx>; Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>; Stefan Hladnik <stefan.hladnik@xxxxxxxxx>; Florian Rebaudo <frebaudo@xxxxxxxxxxx> Subject: Re: [PATCH v2 1/2] media: i2c: Add ON Semiconductor AP1302 ISP driver Hi Anil, On Wed, Aug 04, 2021 at 06:05:54AM +0000, Anil Kumar Mamidala wrote: > Hi Sakari, > > Can you please review ap1302 ISP driver patch. Sorry for the delay in pushing the changes. No worries. Could you elaborate what has changed here since v1? <Anil> Please find the changes list below. 1. Updated code with the review comments from you for patch v1. - Add check for firmware size - Remove hardcoding of MIPI lanes - Use fwnode_graph_get_endpoint_by_id() API instead of fwnode_graph_get_next_endpoint 2. Add streaming flag to avoid multiple times calling of stream on/off functionality if already in that state. 3. Add v4l2_ctrls for setting brightness, saturation, AE metering mode, contrast, gain ctrls. -- Sakari Ailus
