On 07/05/2020 16:05, Mauro Carvalho Chehab wrote: > Em Thu, 7 May 2020 14:36:49 +0200 > Jacopo Mondi <jacopo@xxxxxxxxxx> escreveu: > >> Hi Mauro, >> >> On Wed, May 06, 2020 at 01:28:47PM +0200, Mauro Carvalho Chehab wrote: >>> Em Wed, 6 May 2020 13:07:30 +0200 >>> Jacopo Mondi <jacopo@xxxxxxxxxx> escreveu: >>> >>>>> So, if that would be ok for you, I can live with a >>>>> >>>>> V4L2_CID_CAMERA_VIEWING_ANGLE (or some similar name) that will >>>>> specify the angle where the sensor is mounted (for fixed sensors), >>>>> or the current angle, in case of movable ones, being RO for fixed >>>>> sensors and RW for movable ones. >>>>> >>>>> Let's postpone discussions for a LOCATION control once this >>>>> would be needed by some driver. >>>> >>>> Would V4L2_CID_CAMERA_ORIENTATION work ? >>> >>> Yeah, either V4L2_CID_CAMERA_ORIENTATION or CID_LENS_FACING would >>> equally work (although I would prefer the one with a shorter name). >>> >> >> Yeah, CID_LENS_FACING is nice and shorter, but I would refrain from >> polluting the LENS_ namespace, this control applies to the whole camera >> module, so I would keep it in the CAMERA_ namespace... And >> 'orientation' gives a nice match with the DT property, which I would >> not call 'facing' or 'facing_side' as 'orientation' seems more >> appropriate as a dt-property name to me.. > > Ok. V4L2_CID_CAMERA_ORIENTATION works for me. For me as well. Regards, Hans
