On Tue, 2010-02-23 at 08:53 +0100, Hans Verkuil wrote: > On Monday 22 February 2010 23:00:32 Devin Heitmueller wrote: > > On Mon, Feb 22, 2010 at 4:54 PM, Hans Verkuil <hverkuil@xxxxxxxxx> wrote: > > Of course, if you and Mauro wanted to sign off on the creation of a > > new non-private user control called V4L2_CID_CHROMA_GAIN, that would > > also resolve my problem. :-) > > Hmm, Mauro is right: the color controls we have now are a bit of a mess. > Perhaps this is a good moment to try and fix them. Suppose we had no color > controls at all: how would we design them in that case? When we know what we > really need, then we can compare that with what we have and figure out what > we need to do to make things right again. Hmmm: 1. comb filter enable/disable 2. chroma AGC enable/disable 3. chroma kill threshold and enable/disable 4. UV saturation (C vector magnitude adjustment as long as you adjust U and V in the same way.) 5. Hue (C vector phase adjustment) 6. chroma coring 7. chroma delay/advance in pixels relative to luma pixels 8. chroma subcarrier locking algorithm: fast, slow, adaptive 9. chroma notch filer settings (when doing Y/C separation from CVBS) 10. additional analog signal gain 11. anti-alias filter enable/disable And that's just from a quick scan of the public CX25836/7 datasheet. I left my handbook with all sorts of details about the Human Visual System and the CIE and NTSC and PAL colorspaces at work. Regards, Andy > Regards, > > Hans > > > > > Devin > > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
