On Fri, Dec 6, 2019 at 10:11 PM Markus Elfring <Markus.Elfring@xxxxxx> wrote: > > > go7007_snd_init() misses a snd_card_free() in an error path. > > Add the missed call to fix it. > > How do you think about to take another look also at the previous update suggestion > “[PATCH 5/6] [media] go7007: Use common error handling code in go7007_snd_init()”? > https://lore.kernel.org/linux-media/05efac78-3a14-803c-5b4a-68670728628b@xxxxxxxxxxxxxxxxxxxxx/ > https://lore.kernel.org/patchwork/patch/831887/ > https://lkml.org/lkml/2017/9/19/115 > I think using goto is really much better than freeing after every error. I will send a new version if others also agree with this pattern. Regards, Chuhong > Regards, > Markus
