Re: media: go7007: fix a miss of snd_card_free

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> I think using goto is really much better than freeing after every error.

Thanks for your positive feedback.


> I will send a new version if others also agree with this pattern.

* The error handling pattern would be supported by the Linux coding style.
  The agreement on corresponding changes can occasionally become more challenging.

* I would interpret Dan Carpenter's review comment (from 2017-09-19) in the way
  that he should be mentioned by the tag “Reported-by” in a subsequent patch.
  https://lkml.org/lkml/2017/9/19/115

Regards,
Markus




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux