Hi Sakari, On Thu, Aug 15, 2019 at 09:56:35AM +0300, Sakari Ailus wrote: > On Wed, Aug 14, 2019 at 10:28:11PM +0200, Jacopo Mondi wrote: > > Add the 'location' device property, used to specify the camera device > > mounting position. The property is particularly meaningful for mobile > > devices with a well defined usage orientation. > > > > Signed-off-by: Jacopo Mondi <jacopo@xxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/media/video-interfaces.txt | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt > > index f884ada0bffc..819077b2649c 100644 > > --- a/Documentation/devicetree/bindings/media/video-interfaces.txt > > +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt > > @@ -89,6 +89,10 @@ Optional properties > > but a number of degrees counter clockwise. Typical values are 0 and 180 > > (upside down). > > > > +- location: The camera device mounting position, relative to the device > > + usage orientation. Possible values are: > > + 0 - Front camera. The image sensor is mounted on the front side of the device. > > + 1 - Back camera. The image sensor is mounted on the back side of the device. > > Would it make sense to make this a little more generic? Such as s/image > sensor/ device/, for instance? > > Is this also relevant for flash or lens devices? I certainly hope that the flash or lens will be located on the same side as the sensor... :-) It could however make sense to extend usage of this property yet. I'm not sure I would do so already though, unless you think all flash and lens controllers should really use it. > Flash (torch) devices could be present, at least principle, without a > camera. There once was even such a Nokia phone, 1100 unless I'm mistaken. > :-) -- Regards, Laurent Pinchart
